Re: [PATCH v3] Bluetooth: btintel_pcie: Add support for device 0x4d76

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Kiran,


Thank you for the third iteration of your patch. Sorry to comment once more.

As this is Wild Cat Lake, please add WCL to the summary too, and mention Wild Cat Lake in the commit message body.

Am 21.06.25 um 08:46 schrieb Kiran K:
lspci -v -k -d  8086:4d76
00:14.7 Bluetooth: Intel Corporation Device 4d76
         Subsystem: Intel Corporation Device 0011
         Flags: fast devsel, IRQ 255, IOMMU group 12
         Memory at 13013328000 (64-bit, non-prefetchable) [disabled] [size=16K]
         Capabilities: [c8] Power Management version 3
         Capabilities: [d0] MSI: Enable- Count=1/1 Maskable- 64bit+
         Capabilities: [40] Express Root Complex Integrated Endpoint, MSI 00
         Capabilities: [80] MSI-X: Enable- Count=32 Masked-
         Capabilities: [100] Latency Tolerance Reporting
         Kernel driver in use: btintel_pcie
         Kernel modules: btintel_pcie

Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
---
changes in v3:
- Fix indendtation issue in commit message

  drivers/bluetooth/btintel_pcie.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index cb3cf2b9acea..1113a6310bd0 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -35,6 +35,7 @@
/* Intel Bluetooth PCIe device id table */
  static const struct pci_device_id btintel_pcie_table[] = {
+	{ BTINTEL_PCI_DEVICE(0x4D76, PCI_ANY_ID) },
  	{ BTINTEL_PCI_DEVICE(0xA876, PCI_ANY_ID) },
  	{ BTINTEL_PCI_DEVICE(0xE476, PCI_ANY_ID) },
  	{ 0 }

Searching for 0x4D76, it’s also present in `drivers/net/wireless/intel/iwlwifi/pcie/trans.c` added in commit 9673c35486d4 (wifi: iwlwifi: implement product reset for TOP errors):

		/* on integrated we have to look up by ID (same bus) */
		static const struct pci_device_id bt_device_ids[] = {
#define BT_DEV(_id) { PCI_DEVICE(PCI_VENDOR_ID_INTEL, _id) }
			BT_DEV(0xA876), /* LNL */
			BT_DEV(0xE476), /* PTL-P */
			BT_DEV(0xE376), /* PTL-H */
			BT_DEV(0xD346), /* NVL-H */
			BT_DEV(0x6E74), /* NVL-S */
			BT_DEV(0x4D76), /* WCL */
			BT_DEV(0xD246), /* RZL-H */
			BT_DEV(0x6C46), /* RZL-M */
			{}
		};

Could you add the names as comments in a follow-up commit, and maybe all the other id’s?


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux