Hi Paul,
Thanks for your comments.
>-----Original Message-----
>From: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
>Sent: Tuesday, June 17, 2025 1:51 AM
>To: K, Kiran <kiran.k@xxxxxxxxx>
>Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Srivatsa, Ravishankar
><ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan, Chethan
><chethan.tumkur.narayan@xxxxxxxxx>; Devegowda, Chandrashekar
><chandrashekar.devegowda@xxxxxxxxx>; Aluvala Sai Teja
><aluvala.sai.teja@xxxxxxxxx>
>Subject: Re: [PATCH v1] Bluetooth: btintel: Add support for BlazarIW
>
>Dear Kiran,
>
>
>Thank you for your patch. Maybe for the summary/title:
>
>Bluetooth: btintel: Add BlazarIW TLV id
>
>Am 16.06.25 um 18:26 schrieb Kiran K:
>> Add support for Bluetooth core - BlazarIW over USB and PCIe transport.
>
>A statement, that only ids need to be added, and that support exists, would be
>nice.
I will amend the commit message.
>
>Any datasheet reference? Do you have the hardware, and were able to test
>this?
Sorry, Intel doesn’t release these documents to public. I am able to test this.
>
>> Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
>> ---
>> drivers/bluetooth/btintel.c | 3 +++
>> drivers/bluetooth/btintel_pcie.c | 1 +
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
>> index 55cc1652bfe4..f6805027be0a 100644
>> --- a/drivers/bluetooth/btintel.c
>> +++ b/drivers/bluetooth/btintel.c
>> @@ -484,6 +484,7 @@ int btintel_version_info_tlv(struct hci_dev *hdev,
>> case 0x1d: /* BlazarU (BzrU) */
>> case 0x1e: /* BlazarI (Bzr) */
>> case 0x1f: /* Scorpious Peak */
>> + case 0x22: /* BlazarIW */
>> break;
>> default:
>> bt_dev_err(hdev, "Unsupported Intel hardware variant
>(0x%x)", @@
>> -3253,6 +3254,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8
>hw_variant)
>> case 0x1d:
>> case 0x1e:
>> case 0x1f:
>> + case 0x22:
>> hci_set_msft_opcode(hdev, 0xFC1E);
>> break;
>> default:
>> @@ -3593,6 +3595,7 @@ static int btintel_setup_combined(struct hci_dev
>*hdev)
>> case 0x1d:
>> case 0x1e:
>> case 0x1f:
>> + case 0x22:
>> /* Display version information of TLV type */
>> btintel_version_info_tlv(hdev, &ver_tlv);
>>
>> diff --git a/drivers/bluetooth/btintel_pcie.c
>> b/drivers/bluetooth/btintel_pcie.c
>> index cb3cf2b9acea..1004264128e3 100644
>> --- a/drivers/bluetooth/btintel_pcie.c
>> +++ b/drivers/bluetooth/btintel_pcie.c
>> @@ -2137,6 +2137,7 @@ static int btintel_pcie_setup_internal(struct hci_dev
>*hdev)
>> switch (INTEL_HW_VARIANT(ver_tlv.cnvi_bt)) {
>> case 0x1e: /* BzrI */
>> case 0x1f: /* ScP */
>> + case 0x22: /* BlazarIW */
>> /* Display version information of TLV type */
>> btintel_version_info_tlv(hdev, &ver_tlv);
>>
>
>
>Kind regards,
>
>Paul
Thanks,
Kiran
