[PATCH BlueZ v1] bap: Fix not responding to SetConfiguration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>

For broadcast the SetConfiguration would call setup_config which were
not calling the callback so no reply was generated which brakes the
likes of client/script/broadcast-source.bt as endpoint.config would not
complete without a reply.
---
 profiles/audio/bap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 513e207d1424..66403fcb7997 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -1170,6 +1170,7 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg,
 
 	cbdata = new0(struct set_configuration_data, 1);
 	cbdata->setup = setup;
+	cbdata->msg = dbus_message_ref(msg);
 
 	if (setup_config(setup, set_configuration_ready, cbdata)) {
 		DBG("Unable to config stream");
@@ -1178,8 +1179,6 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg,
 		return btd_error_invalid_args(msg);
 	}
 
-	cbdata->msg = dbus_message_ref(msg);
-
 	switch (bt_bap_stream_get_type(setup->stream)) {
 	case BT_BAP_STREAM_TYPE_BCAST:
 		if (ep->data->service)
@@ -1776,6 +1775,7 @@ static int setup_config(struct bap_setup *setup, bap_setup_ready_func_t cb,
 	case BT_BAP_STREAM_TYPE_BCAST:
 		/* Broadcast does not call the callback */
 		setup->id = 0;
+		cb(setup, 0, 0, user_data);
 		break;
 	}
 
-- 
2.49.0





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux