On 27/05/2025 09:47, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Commit 3d05fc82237a ("Bluetooth: qca: set power_ctrl_enabled on NULL > returned by gpiod_get_optional()") accidentally changed the prevous > behavior where power control would be disabled without the BT_EN GPIO > only on QCA_WCN6750 and QCA_WCN6855 while also getting the error check > wrong. We should treat every IS_ERR() return value from > devm_gpiod_get_optional() as a reason to bail-out while we should only > set power_ctrl_enabled to false on the two models mentioned above. While > at it: use dev_err_probe() to save a LOC. ... and to fix spamming kernel logs on deferred probe. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof