Dear Kiran,
Thank you for the patch.
Am 25.05.25 um 07:39 schrieb Kiran K:
The driver was posting only 6 rx buffers, despite the maximum rx buffers
being defined as 16.
The second part is worded strangely, as the macro, you remove, is
defined to be 6. Was it just a typo?
Update the driver to post the full 16 Rx buffers to
utilize the maximum capacity and improve performance.
Please also note, that you remove the macro, because the value seems to
be detectable.
Please also mention, how your change can be verified, for example read
out in the logs or from /sys, and how the performance can be measured,
and what you measured before and after. (Claimns regarding performance
should always come with measurements.)
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@xxxxxxxxx>
Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
Fixes: c2b636b3f788 ("Bluetooth: btintel_pcie: Add support for PCIe transport")
---
drivers/bluetooth/btintel_pcie.c | 3 ++-
drivers/bluetooth/btintel_pcie.h | 3 ---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 50fe17f1e1d1..2c7731803c9f 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -396,8 +396,9 @@ static int btintel_pcie_submit_rx(struct btintel_pcie_data *data)
static int btintel_pcie_start_rx(struct btintel_pcie_data *data)
{
int i, ret;
+ struct rxq *rxq = &data->rxq;
- for (i = 0; i < BTINTEL_PCIE_RX_MAX_QUEUE; i++) {
+ for (i = 0; i < rxq->count; i++) {
ret = btintel_pcie_submit_rx(data);
if (ret)
return ret;
diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
index 21b964b15c1c..5ddd6d7d8d45 100644
--- a/drivers/bluetooth/btintel_pcie.h
+++ b/drivers/bluetooth/btintel_pcie.h
@@ -177,9 +177,6 @@ enum {
/* Doorbell vector for TFD */
#define BTINTEL_PCIE_TX_DB_VEC 0
-/* Number of pending RX requests for downlink */
-#define BTINTEL_PCIE_RX_MAX_QUEUE 6
-
/* Doorbell vector for FRBD */
#define BTINTEL_PCIE_RX_DB_VEC 513
Kind regards,
Paul
