On Tue, 2025-05-13 at 11:51 -0400, Luiz Augusto von Dentz wrote: > Is the flag above really required though, I mean the bt_shell_run > shall only be run once and even if that is no the case the shell > itself could be doing the checking if the submenu.pre_run has been > called, anyway if that is required Id say we do this in a separate > patch, just let me know since I can drop the use of pre_run_done flag > while applying these changes. You're right, you can drop it. I don't know why, I thought that bt_shell_run() was being run for every user-provided command when run. That's the problem with coming back to work on patches months after another iteration... Feel free to remove the pre_run_done checks before merging Thanks for the quick review!
