Re: [PATCH] Bluetooth: fix socket matching ambiguity between BIS and CIS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luzi,
[ EXTERNAL EMAIL ]

Hi,

On Thu, May 8, 2025 at 2:54 AM kernel test robot <lkp@xxxxxxxxx> wrote:
Hi Yang,

kernel test robot noticed the following build errors:

[auto build test ERROR on f3daca9b490154fbb0459848cc2ed61e8367bddc]

url:    https://github.com/intel-lab-lkp/linux/commits/Yang-Li-via-B4-Relay/Bluetooth-fix-socket-matching-ambiguity-between-BIS-and-CIS/20250507-153347
base:   f3daca9b490154fbb0459848cc2ed61e8367bddc
patch link:    https://lore.kernel.org/r/20250507-iso-v1-1-6f60d243e037%40amlogic.com
patch subject: [PATCH] Bluetooth: fix socket matching ambiguity between BIS and CIS
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250508/202505081427.1Y3wyo7v-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250508/202505081427.1Y3wyo7v-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505081427.1Y3wyo7v-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

    net/bluetooth/hci_event.c: In function 'hci_le_per_adv_report_evt':
net/bluetooth/hci_event.c:6469:60: error: 'ISO_LINK' undeclared (first use in this function); did you mean 'SCO_LINK'?
     6469 |         mask |= hci_proto_connect_ind(hdev, &pa_sync->dst, ISO_LINK, &flags);
          |                                                            ^~~~~~~~
          |                                                            SCO_LINK
    net/bluetooth/hci_event.c:6469:60: note: each undeclared identifier is reported only once for each function it appears in
    net/bluetooth/hci_event.c: In function 'hci_le_big_info_adv_report_evt':
    net/bluetooth/hci_event.c:7055:60: error: 'ISO_LINK' undeclared (first use in this function); did you mean 'SCO_LINK'?
     7055 |         mask |= hci_proto_connect_ind(hdev, &pa_sync->dst, ISO_LINK, &flags);
          |                                                            ^~~~~~~~
          |                                                            SCO_LINK


vim +6469 net/bluetooth/hci_event.c

   6449
   6450  static void hci_le_per_adv_report_evt(struct hci_dev *hdev, void *data,
   6451                                        struct sk_buff *skb)
   6452  {
   6453          struct hci_ev_le_per_adv_report *ev = data;
   6454          int mask = hdev->link_mode;
   6455          __u8 flags = 0;
   6456          struct hci_conn *pa_sync;
   6457
   6458          bt_dev_dbg(hdev, "sync_handle 0x%4.4x", le16_to_cpu(ev->sync_handle));
   6459
   6460          hci_dev_lock(hdev);
   6461
   6462          pa_sync = hci_conn_hash_lookup_pa_sync_handle
   6463                          (hdev,
   6464                          le16_to_cpu(ev->sync_handle));
   6465
   6466          if (!pa_sync)
   6467                  goto unlock;
   6468
6469          mask |= hci_proto_connect_ind(hdev, &pa_sync->dst, ISO_LINK, &flags);
   6470          if (!(mask & HCI_LM_ACCEPT))
   6471                  goto unlock;
   6472
   6473          if (!(flags & HCI_PROTO_DEFER))
   6474                  goto unlock;
   6475
   6476          if (ev->data_status == LE_PA_DATA_COMPLETE &&
   6477              !test_and_set_bit(HCI_CONN_PA_SYNC, &pa_sync->flags)) {
   6478                  /* Notify iso layer */
   6479                  hci_connect_cfm(pa_sync, 0);
   6480
   6481                  /* Notify MGMT layer */
   6482                  mgmt_device_connected(hdev, pa_sync, NULL, 0);
   6483          }
   6484
   6485  unlock:
   6486          hci_dev_unlock(hdev);
   6487  }
   6488

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
This is probably already solved by:

https://github.com/bluez/bluetooth-next/commit/f3daca9b490154fbb0459848cc2ed61e8367bddc


I'm currently working with kernel 6.12, but this patch seems to conflict with it. Do you know if there's a plan to backport it to v6.12?


--
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux