Re: [PATCH BlueZ bluez v2] bass: Set the service connection flag when BASS connected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,
A gentle ping, thanks.

Hi Luiz,


[ EXTERNAL EMAIL ]

Hi Yang,

On Wed, Apr 2, 2025 at 11:37 PM Yang Li via B4 Relay
<devnull+yang.li.amlogic.com@xxxxxxxxxx> wrote:
From: Yang Li <yang.li@xxxxxxxxxxx>

When BASS serice connected, set the service states to
BTD_SERVICE_STATE_CONNECTED. Otherwise, the device will
timeout and be removed, triggering the automatic termination
  of BIG.

issue: https://github.com/bluez/bluez/issues/1144

Signed-off-by: Yang Li <yang.li@xxxxxxxxxxx>
---
Changes in v2:
- Set the BASS service connection success flag in the connect_cb function. - Link to v1: https://patch.msgid.link/20250402-bass-v1-1-3e753841faa5@xxxxxxxxxxx
---
  profiles/audio/bass.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
index c36f43277..c28d9d1ad 100644
--- a/profiles/audio/bass.c
+++ b/profiles/audio/bass.c
@@ -321,6 +321,8 @@ static void connect_cb(GIOChannel *io, GError *err, void *user_data)
         if (bt_bap_stream_set_io(stream, fd)) {
                 g_io_channel_set_close_on_unref(io, FALSE);
         }
+
+ btd_service_connecting_complete(setup->dg->service, 0);
Ok, do we mark it as disconnected when the BIS is disconnected?

Yes, the service will be marked as disconnected after the BASS service is disconnected.

static int bass_disconnect(struct btd_service *service)
{
    ......
    btd_service_disconnecting_complete(service, 0);

    return 0;
}

In
case we are acting as assistante then there is probably no reason to
keep the device object around after it has been pushed to the remote
sink.
I don't think so. As an Assistant, the mobile phone needs to record the source information configured for the BIS sink. The record of the source device will only be cleared when the BIS source is removed.
  }

  static bool link_enabled(const void *data, const void *match_data)

---
base-commit: 0efa20cbf3fb5693c7c2f14ba8cf67053ca029e5
change-id: 20250402-bass-66200bb7eba1

Best regards,
--
Yang Li <yang.li@xxxxxxxxxxx>




--
Luiz Augusto von Dentz






[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux