Branch: refs/heads/958828 Home: https://github.com/bluez/bluez Commit: 418352cc036404fcb388431a6c834369ba31783f https://github.com/bluez/bluez/commit/418352cc036404fcb388431a6c834369ba31783f Author: Thomas Perale <thomas.perale@xxxxxxx> Date: 2025-05-01 (Thu, 01 May 2025) Changed paths: M profiles/input/device.h M profiles/input/hog.c M profiles/input/manager.c Log Message: ----------- input: fix HID compilation w/o HoG Commit [1] introduced a dependency with the HID plugin in the HoG code As a result, building with --enable-hid --disable-hog caused linker errors due to undefined references to HoG-related functions: ``` > ./configure --enable-hid --disable-hog ... > make ... CCLD src/bluetoothd /usr/bin/ld: profiles/input/bluetoothd-manager.o: in function `input_init': /home/../bluez/profiles/input/manager.c:122:(.text.input_init+0x1c8): undefined reference to `input_set_auto_sec' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:6376: src/bluetoothd] Error 1 ``` This patch moves the reading of the HOG specific configuration of the 'input.conf' file: LEAutoSecurity, to the HoG plugin file. [1] f2778f587 input: Add LEAutoSecurity setting to input.conf Commit: b623954f429620fbb32e8f9daae2c6918d7b7ee5 https://github.com/bluez/bluez/commit/b623954f429620fbb32e8f9daae2c6918d7b7ee5 Author: Thomas Perale <thomas.perale@xxxxxxx> Date: 2025-05-01 (Thu, 01 May 2025) Changed paths: M profiles/input/device.c M profiles/input/device.h M profiles/input/hog.c Log Message: ----------- input: fix HoG compilation w/o HID Commit [1] introduced a dependency with the HID plugin in the HoG code As a result, building with --disable-hid --enable-hog caused linker errors due to undefined references to HID-related functions: ``` > ./configure --disable-hid --enable-hog > make /usr/bin/ld: profiles/input/bluetoothd-hog.o: in function `hog_accept': /home/../bluez/profiles/input/hog.c:184:(.text.hog_accept+0xbb): undefined reference to `input_get_auto_sec' /usr/bin/ld: profiles/input/bluetoothd-hog.o: in function `hog_disconnect': /home/../bluez/profiles/input/hog.c:205:(.text.hog_disconnect+0x12): undefined reference to `input_get_userspace_hid' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:6344: src/bluetoothd] Error 1 make: *** [Makefile:4695: all] Error 2 ``` This patch duplicate the read of the 'UserspaceHID=persist' config entry in the HoG plugin file to remove the dependency on the HID plugin files. [1] 1782bfd79 input: Add support for UserspaceHID=persist Fixes: https://github.com/bluez/bluez/issues/1228 Compare: https://github.com/bluez/bluez/compare/418352cc0364%5E...b623954f4296 To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
