Branch: refs/heads/958531 Home: https://github.com/bluez/bluez Commit: b923226f335d25879498196e3113736968a976c6 https://github.com/bluez/bluez/commit/b923226f335d25879498196e3113736968a976c6 Author: Andrew Sayers <kernel.org@xxxxxxxxxxxxxxx> Date: 2025-04-30 (Wed, 30 Apr 2025) Changed paths: M Makefile.obexd M obexd/client/pbap.c M obexd/plugins/bluetooth.c A obexd/src/logind.c A obexd/src/logind.h M obexd/src/main.c Log Message: ----------- obexd: Unregister profiles when the user is inactive Obexd is usually run as a user service, and can exhibit surprising behaviour if two users are logged in at the same time. Unregister profiles when the user is detected to be off-seat. It may be impossible to detect whether a user is on-seat in some cases. For example, a version of obexd compiled with systemd support might be run outside of a systemd environment. Warn and leave services registered if that happens. Obexd can be run as a system service, in which case this check makes no sense. Disable this check when called with `--system-bus`. Obexd can also be run by a user that does not have an active session. For example, someone could use `ssh` to access the system. There might be a use case where someone needs Bluetooth access but can't log in with a keyboard, or there might be a security issue with doing so. This isn't handled explicitly by this patch, but a future patch could add support by calling `logind_set(FALSE)` in the same way as is currently done with `--system-bus`. Unregister profiles by closing private connections instead of sending UnregisterProfile on the shared connection. Pipewire has apparently found the latter to cause long shutdown delays, because bluetoothd may be shutting down and unable to handle this message. Based in large part on the wireplumber code mentioned by Pauli Virtanen: https://gitlab.freedesktop.org/pipewire/wireplumber/-/blob/master/modules/module-logind.c#L52 Other services are likely to need similar functionality, so I have created a gist to demonstrate the basic technique: https://gist.github.com/andrew-sayers/1c4a24f86a9a4c1b1e38d109f1bd1d1e Suggested-by: Pauli Virtanen <pav@xxxxxx> Signed-off-by: Andrew Sayers <kernel.org@xxxxxxxxxxxxxxx> Commit: 4dbe23c5e1c4659044b50e689000c5602a839ff9 https://github.com/bluez/bluez/commit/4dbe23c5e1c4659044b50e689000c5602a839ff9 Author: Andrew Sayers <kernel.org@xxxxxxxxxxxxxxx> Date: 2025-04-30 (Wed, 30 Apr 2025) Changed paths: M obexd/src/logind.c Log Message: ----------- obexd: Support sd_login_monitor_get_timeout() The documentation for sd_login_monitor_get_timeout() implies the API may need to be checked after some time, even if no events have been received via the fd. In practice, the implementation has always returned a dummy value, and changing it now would cause enough breakage in other projects to make it unlikely to ever happen. Add a handler for that case, even though it can't currently happen in the real world. The API assumes we call poll() directly, so in theory it could change the timeout based on some event that doesn't trigger a callback (e.g. sending a signal to the service). It's hard to see how we'd handle that without running a poll() in a separate thread, which would be a lot of complexity for an untestable edge case. Don't try to handle that problem. Cc: Pauli Virtanen <pav@xxxxxx> Signed-off-by: Andrew Sayers <kernel.org@xxxxxxxxxxxxxxx> Commit: 771c0db8b02f4e688725d39c0c52afae3b6128a5 https://github.com/bluez/bluez/commit/771c0db8b02f4e688725d39c0c52afae3b6128a5 Author: Andrew Sayers <kernel.org@xxxxxxxxxxxxxxx> Date: 2025-04-30 (Wed, 30 Apr 2025) Changed paths: M obexd/src/obex.service.in Log Message: ----------- Revert "obexd: only run one instance at once" No longer needed now services can share resources. This reverts commit 8d472b8758dcdd89bf13cf2fb06a8846e1f483a0. Signed-off-by: Andrew Sayers <kernel.org@xxxxxxxxxxxxxxx> Compare: https://github.com/bluez/bluez/compare/b923226f335d%5E...771c0db8b02f To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
