Re: [PATCH] drivers: bluetooth: bpa10x: use usb_{get,put}_dev in bpa10x_{probe,disconnect}

[Paul Menzel <pmenzel@xxxxxxxxxxxxx>]

Dear Salah,


Thank you for your patch.

Am 27.04.25 um 18:23 schrieb Salah Triki:
> Use usb_{get,put}_dev() to update the ref count of udev.

Could you please add why that is better?

> Signed-off-by: Salah Triki <salah.triki@xxxxxxxxx>
> ---
>   drivers/bluetooth/bpa10x.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c
> index 1fa58c059cbf..0b9931311a59 100644
> --- a/drivers/bluetooth/bpa10x.c
> +++ b/drivers/bluetooth/bpa10x.c
> @@ -375,7 +375,7 @@ static int bpa10x_probe(struct usb_interface *intf,
>   	if (!data)
>   		return -ENOMEM;
>   
> -	data->udev = interface_to_usbdev(intf);
> +	data->udev = usb_get_dev(interface_to_usbdev(intf));
>   
>   	init_usb_anchor(&data->tx_anchor);
>   	init_usb_anchor(&data->rx_anchor);
> @@ -422,6 +422,8 @@ static void bpa10x_disconnect(struct usb_interface *intf)
>   
>   	usb_set_intfdata(intf, NULL);
>   
> +	usb_put_dev(data->udev);
> +
>   	hci_unregister_dev(data->hdev);
>   
>   	hci_free_dev(data->hdev);


Kind regards,

Paul