On Tue, Apr 15, 2025 at 09:15:19AM -0700, Kees Cook wrote: > Avoid double-copying of string literals. Use a "const char *" for each > string instead of copying from .rodata into stack and then into the skb. > We can go directly from .rodata to the skb. > > This also works around a Clang bug (that has since been fixed[1]). > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202401250927.1poZERd6-lkp@xxxxxxxxx/ > Fixes: ab4e4380d4e1 ("Bluetooth: Add vhci devcoredump support") > Link: https://github.com/llvm/llvm-project/commit/ea2e66aa8b6e363b89df66dc44275a0d7ecd70ce [1] > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Kees Cook <kees@xxxxxxxxxx> Thanks! Reviewed-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> -- Josh
