On 9/23/25 9:59 AM, Bart Van Assche wrote: > On 9/23/25 12:51 AM, John Garry wrote: >> On 22/09/2025 21:13, Bart Van Assche wrote: >>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c >>> index 0602ca7f1e37..271fa005c51e 100644 >>> --- a/block/blk-mq-tag.c >>> +++ b/block/blk-mq-tag.c >>> @@ -297,15 +297,15 @@ static bool bt_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data) >>> /** >>> * bt_for_each - iterate over the requests associated with a hardware queue >>> * @hctx: Hardware queue to examine. >>> - * @q: Request queue to examine. >>> + * @q: Request queue @hctx is associated with (@hctx->queue). >> >> eh, sometimes hctx is NULL, so it is odd to be saying that it is the q is associated with that (being NULL) > > Thanks for the feedback John. > > Jens, please let me know whether you want me to address this feedback in > a follow-up patch or by posting a second version of this patch. As per my applied email, it's already applied. And it's sitting a few patches down at this point. I don't think there's a rush in fixing a comment, so perhaps just do it next time you're touching that area anyway. -- Jens Axboe
