One file per vendor, or device, is a bit excessive for two-four rules. If possible, select round-robin (>=5.1), or queue-depth (>=6.11). round-robin is a basic selector, and only works well under ideal conditions. A nvme benchmark, round-robin vs queue-depth, shows how bad it is: https://marc.info/?l=linux-kernel&m=171931850925572 https://marc.info/?l=linux-kernel&m=171931852025575 https://github.com/johnmeneghini/iopolicy/?tab=readme-ov-file#sample-data https://people.redhat.com/jmeneghi/ALPSS_2023/NVMe_QD_Multipathing.pdf [ctrl_loss_tmo default value is 600 (ten minutes)] v2: - fix ctrl_loss_tmo commnent - add Infinidat/InfiniBox Cc: Wayne Berthiaume <Wayne.Berthiaume@xxxxxxxx> Cc: Vasuki Manikarnike <vasuki.manikarnike@xxxxxxx> Cc: Matthias Rudolph <Matthias.Rudolph@xxxxxxxxxxxxxxxxxx> Cc: Martin George <marting@xxxxxxxxxx> Cc: NetApp RDAC team <ng-eseries-upstream-maintainers@xxxxxxxxxx> Cc: Zou Ming <zouming.zouming@xxxxxxxxxx> Cc: Li Xiaokeng <lixiaokeng@xxxxxxxxxx> Cc: Randy Jennings <randyj@xxxxxxxxxxxxxxx> Cc: Jyoti Rani <jrani@xxxxxxxxxxxxxxx> Cc: Brian Bunker <brian@xxxxxxxxxxxxxxx> Cc: Uday Shankar <ushankar@xxxxxxxxxxxxxxx> Cc: Chaitanya Kulkarni <kch@xxxxxxxxxx> Cc: Sagi Grimberg <sagi@xxxxxxxxxxx> Cc: Keith Busch <kbusch@xxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Cc: Marco Patalano <mpatalan@xxxxxxxxxx> Cc: Ewan D. Milne <emilne@xxxxxxxxxx> Cc: John Meneghini <jmeneghi@xxxxxxxxxx> Cc: Daniel Wagner <dwagner@xxxxxxx> Cc: Daniel Wagner <wagi@xxxxxxxxx> Cc: Hannes Reinecke <hare@xxxxxxx> Cc: Martin Wilck <mwilck@xxxxxxxx> Cc: Benjamin Marzinski <bmarzins@xxxxxxxxxx> Cc: Christophe Varoqui <christophe.varoqui@xxxxxxxxxxx> Cc: BLOCK-ML <linux-block@xxxxxxxxxxxxxxx> Cc: NVME-ML <linux-nvme@xxxxxxxxxxxxxxxxxxx> Cc: SCSI-ML <linux-scsi@xxxxxxxxxxxxxxx> Cc: DM_DEVEL-ML <dm-devel@xxxxxxxxxxxxxxx> Signed-off-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx> --- Maybe these rules should be merged into this new file. ??? 71-nvmf-hpe.rules.in 71-nvmf-netapp.rules.in 71-nvmf-vastdata.rules.in --- .../80-nvmf-storage_arrays.rules.in | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in diff --git a/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in b/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in new file mode 100644 index 00000000..ceabba31 --- /dev/null +++ b/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in @@ -0,0 +1,38 @@ +##### Storage arrays + +#### Set iopolicy for NVMe-oF +### iopolicy: numa, round-robin (>=5.1), or queue-depth (>=6.11) + +## Dell EMC +# PowerMax +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="EMC PowerMax" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="EMC PowerMax" +# PowerStore +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="dellemc-powerstore" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="dellemc-powerstore" + +## Huawei +# OceanStor +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="Huawei-XSG1" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="Huawei-XSG1" + +## IBM +# FlashSystem (RamSan) +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="FlashSystem" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="FlashSystem" +# FlashSystem (Storwize/SVC) +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="IBM*214" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="IBM*214" + +## Infinidat +# InfiniBox +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="InfiniBox" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="InfiniBox" + +## Pure +# FlashArray +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="Pure Storage FlashArray" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="Pure Storage FlashArray" + + +##### EOF -- 2.50.1