> allow_barrier(conf); > + bio = bio_submit_split(bio, max_sectors, &conf->bio_split); > wait_barrier(conf, false); > + > + if (!bio) { > + set_bit(R10BIO_Returned, &r10_bio->state); > + goto err_handle; > + } The NULL return should only happen for REQ_NOWAIT here, so maybe give R10BIO_Returned a more descriptive name? Also please document the flag in the header. Any maybe yhe code wants a splitting helper instead of open coding setting this flag in multiple places?