On Tue, Aug 26, 2025 at 10:02:00AM +0200, Christoph Hellwig wrote: > On Mon, Aug 25, 2025 at 06:37:05PM -0600, Keith Busch wrote: > > bio_iov_iter_get_pages() might submit the segments as separate IO's > > anyway for other reasons. I am not sure why the alignment conditions are > > handled specifically here. > > I'll take another look. Basically what this wants to prevent is > bio_iov_iter_get_pages creating bios not aligned to file system > block size. Got it, I think we're okay in that case. You should only need to consider the ki_pos and the iov_iter_count to align to the filesystem block size. This patch will dispatch appropriately sized IO as long as the hw limits allow it, and you'll get an error (same as before) if it doesn't.