On 8/30/25 13:10, Yu Kuai wrote: > Hi, > > 在 2025/8/30 8:41, Damien Le Moal 写道: >> On 8/28/25 15:57, Yu Kuai wrote: >>> From: Yu Kuai <yukuai3@xxxxxxxxxx> >>> >>> On the one hand unify bio split code, prepare to fix disordered split >>> IO; On the other hand fix missing blkcg_bio_issue_init() and >>> trace_block_split() for split IO. >> Hmmm... Shouldn't that be a prep patch with a fixes tag for backport ? >> Because that "fix" here is not done directly but is the result of calling >> bio_submit_split_bioset(). > > I can add a fix tag as blkcg_bio_issue_init() and trace_block_split() is missed, > however, if we consider stable backport, should we fix this directly from caller > first? As this is better for backport. Later this patch can be just considered > cleanup. That is what I was suggesting: fix the blkcg issue first withe fixes tag and then do the conversion to using bio_submit_split_bioset() in later patch that is not to be backported. -- Damien Le Moal Western Digital Research
