Re: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Sep 2025 06:29:54 -0700
Cc: hch@xxxxxxxxxxxxx, colyli@xxxxxxxxxx, hare@xxxxxxx, dlemoal@xxxxxxxxxx, tieren@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx, axboe@xxxxxxxxx, tj@xxxxxxxxxx, josef@xxxxxxxxxxxxxx, song@xxxxxxxxxx, kmo@xxxxxxxxxxxxx, satyat@xxxxxxxxxx, ebiggers@xxxxxxxxxx, neil@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, cgroups@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, yukuai3@xxxxxxxxxx, yi.zhang@xxxxxxxxxx, yangerkun@xxxxxxxxxx, johnny.chenyi@xxxxxxxxxx
In-reply-to: <20250901033220.42982-7-yukuai1@huaweicloud.com>
References: <20250901033220.42982-1-yukuai1@huaweicloud.com> <20250901033220.42982-7-yukuai1@huaweicloud.com>

On Mon, Sep 01, 2025 at 11:32:11AM +0800, Yu Kuai wrote:
> +		bio = bio_submit_split_bioset(
> +				bio, zone->zone_end - bio->bi_iter.bi_sector,
> +				&mddev->bio_set);

Nit: this would be a bit more readable as:

		bio = bio_submit_split_bioset(bio,
				zone->zone_end - bio->bi_iter.bi_sector,
				&mddev->bio_set);

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH RFC v3 00/15] block: fix disordered IO in the case recursive split
  - From: Yu Kuai
- [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset()
  - From: Yu Kuai

Prev by Date: Re: [PATCH RFC v3 01/15] block: cleanup bio_issue
Next by Date: Re: [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO_ISSUE
Previous by thread: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset()
Next by thread: Re: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]