…
> it avoids writing out a condition that is unnecessary. Let's drop such
Thus?
> unnecessary conditions.
an unnecessary condition?
Would a summary phrase like “Avoid redundant condition in elv_rb_add()”
be nicer?
…
> +++ b/block/elevator.c
> @@ -240,7 +240,7 @@ void elv_rb_add(struct rb_root *root, struct request *rq)
>
> if (blk_rq_pos(rq) < blk_rq_pos(__rq))
> p = &(*p)->rb_left;
> - else if (blk_rq_pos(rq) >= blk_rq_pos(__rq))
> + else
> p = &(*p)->rb_right;
Would you dare to apply a conditional expression here?
p = (blk_rq_pos(rq) < blk_rq_pos(__rq)) ? &(*p)->rb_left : &(*p)->rb_right;
Regards,
Markus
