Re: remove the bi_inline_vecs field struct bio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 08 Sep 2025 12:56:37 +0200, Christoph Hellwig wrote:
> the bi_inline_vecs causes sparse to warn when a bio is embedded into a
> structure, but not the last member.   This is a bit annoying but
> probably not a big.  But it can be easily fixed by just removing the
> member and doing pointer arithmetics in a helper, so do that.
> 
> Diffstat:
>  block/bio.c                        |   10 +++++++---
>  block/blk-crypto-fallback.c        |    3 +--
>  block/blk-map.c                    |    8 ++++----
>  drivers/md/bcache/debug.c          |    3 +--
>  drivers/md/bcache/io.c             |    3 +--
>  drivers/md/bcache/journal.c        |    2 +-
>  drivers/md/bcache/movinggc.c       |    8 ++++----
>  drivers/md/bcache/super.c          |    2 +-
>  drivers/md/bcache/writeback.c      |    8 ++++----
>  drivers/md/dm-bufio.c              |    2 +-
>  drivers/md/dm-flakey.c             |    2 +-
>  drivers/md/dm-vdo/vio.c            |    2 +-
>  drivers/md/raid1.c                 |    2 +-
>  drivers/md/raid10.c                |    4 ++--
>  drivers/target/target_core_pscsi.c |    2 +-
>  fs/bcachefs/btree_io.c             |    2 +-
>  fs/bcachefs/data_update.h          |    1 -
>  fs/bcachefs/journal.c              |    6 +++---
>  fs/bcachefs/journal_io.c           |    2 +-
>  fs/bcachefs/super-io.c             |    2 +-
>  fs/squashfs/block.c                |    2 +-
>  include/linux/bio.h                |    5 +++++
>  include/linux/blk_types.h          |   12 +++++-------
>  23 files changed, 48 insertions(+), 45 deletions(-)
> 
> [...]

Applied, thanks!

[1/2] block: add a bio_init_inline helper
      commit: 70a6f71b1a77decfc5b1db426ccbe914b58adb38
[2/2] block: remove the bi_inline_vecs variable sized array from struct bio
      commit: d86eaa0f3c56da286853b698b45c8ce404291082

Best regards,
-- 
Jens Axboe







[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux