On 8/13/2025 9:01 PM, Keith Busch wrote: > + * blk_rq_integrity_dma_map_iter_start - map the next integrity DMA segment for > + * a request > + * @req: request to map > + * @dma_dev: device to map to > + * @state: DMA IOVA state > + * @iter: block layer DMA iterator > + * > + * Iterate to the next integrity mapping after a previous call to > + * blk_rq_integrity_dma_map_iter_start(). See there for a detailed description > + * of the arguments. > + * > + * Returns %false if there is no segment to map, including due to an error, or > + * %true if it did map a segment. > + * > + * If a segment was mapped, the DMA address for it is returned in @iter.addr and > + * the length in @iter.len. If no segment was mapped the status code is > + * returned in @iter.status. > + */ > +bool blk_rq_integrity_dma_map_iter_next(struct request *req, > + struct device *dma_dev, struct blk_dma_iter *iter) > +{ The function comment should also use the name "blk_rq_integrity_dma_map_iter_next". Otherwise, looks good. Reviewed-by: Kanchan Joshi <joshi.k@xxxxxxxxxxx>