> On 11 Jul 2025, at 08:43, Andreas Hindborg <a.hindborg@xxxxxxxxxx> wrote:
>
> Clean up the import statements in `gen_disk.rs` to make the code easier to
> maintain.
>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
> ---
> rust/kernel/block/mq/gen_disk.rs | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/rust/kernel/block/mq/gen_disk.rs b/rust/kernel/block/mq/gen_disk.rs
> index cd54cd64ea88..679ee1bb2195 100644
> --- a/rust/kernel/block/mq/gen_disk.rs
> +++ b/rust/kernel/block/mq/gen_disk.rs
> @@ -5,9 +5,13 @@
> //! C header: [`include/linux/blkdev.h`](srctree/include/linux/blkdev.h)
> //! C header: [`include/linux/blk_mq.h`](srctree/include/linux/blk_mq.h)
>
> -use crate::block::mq::{raw_writer::RawWriter, Operations, TagSet};
> -use crate::{bindings, error::from_err_ptr, error::Result, sync::Arc};
> -use crate::{error, static_lock_class};
> +use crate::{
> + bindings,
> + block::mq::{raw_writer::RawWriter, Operations, TagSet},
> + error::{self, from_err_ptr, Result},
> + static_lock_class,
> + sync::Arc,
> +};
> use core::fmt::{self, Write};
>
> /// A builder for [`GenDisk`].
>
> --
> 2.47.2
>
>
>
Same comment as the preceding “import” patch: this is syntax is problematic.
Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
