On Mon, Jul 28, 2025 at 02:55:53PM -0600, Alex Williamson wrote: > On Wed, 23 Jul 2025 16:00:10 +0300 > Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > > From: Vivek Kasireddy <vivek.kasireddy@xxxxxxxxx> > > > > There is no need to share the main device pointer (struct vfio_device *) > > with all the feature functions as they only need the core device > > pointer. Therefore, extract the core device pointer once in the > > caller (vfio_pci_core_ioctl_feature) and share it instead. > > > > Signed-off-by: Vivek Kasireddy <vivek.kasireddy@xxxxxxxxx> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> > > --- > > drivers/vfio/pci/vfio_pci_core.c | 30 +++++++++++++----------------- > > 1 file changed, 13 insertions(+), 17 deletions(-) <...> > > static int vfio_pci_core_pm_entry_with_wakeup( > > - struct vfio_device *device, u32 flags, > > + struct vfio_pci_core_device *vdev, u32 flags, > > struct vfio_device_low_power_entry_with_wakeup __user *arg, > > size_t argsz) > > I'm tempted to fix the line wrapping here, but I think this patch > stands on its own. Even if it's rather trivial, it makes sense to > consolidate and standardize on the vfio_pci_core_device getting passed > around within vfio_pci_core.c. Any reason not to split this off? No problem, I will send it separately after merge window ends. Thanks > Thanks, > > Alex
