On Fri, Jul 25, 2025, at 18:43, Klara Modin wrote:
> When introduced in commit 9eb22f7fedfc ("fs: add ioctl to query metadata
> and protection info capabilities") the stub of blk_get_meta_cap() for
> !BLK_DEV_INTEGRITY always returns -EOPNOTSUPP. The motivation was that
> while the command was unsupported in that configuration it was still
> recognized.
>
> A later change instead assumed -ENOIOCTLCMD as is required for unknown
> ioctl commands per Documentation/driver-api/ioctl.rst. The result being
> that on !BLK_DEV_INTEGRITY configs, any ioctl which reaches
> blkdev_common_ioctl() will return -EOPNOTSUPP.
>
> Change the stub to return -ENOIOCTLCMD, fixing the issue and better
> matching with expectations.
>
> Link:
> https://lore.kernel.org/lkml/CACzX3AsRd__fXb9=CJPTTJC494SDnYAtYrN2=+bZgMCvM6UQDg@xxxxxxxxxxxxxx
> Fixes: 42b0ef01e6b5 ("block: fix FS_IOC_GETLBMD_CAP parsing in
> blkdev_common_ioctl()")
> Signed-off-by: Klara Modin <klarasmodin@xxxxxxxxx>
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
Thanks for the fix!
