Hi Al! > Instances of ->getgeo() get a block_device of partition and > fill the (mostly fake) geometry information of the disk into caller's > struct hd_geometry. It *does* contain one member related to specific > partition (the starting sector), but... that member is actually filled > by the callers of ->getgeo() (blkdev_getgeo() and compat_hdio_getgeo()), > leaving the instances partition-agnostic. > > All actual work is done using bdev->bd_disk, be it the disk > capacity, IO, or cached geometry information. AFAICS, it would make > more sense to pass it gendisk to start with. > > The series is pretty straightforward - conversion of scsi_bios_ptable() > and scsi_partsize() to gendisk, then the same for ->bios_param(), then > ->getgeo() itself. It sits in viro/vfs.git#rebase.getgeo, individual patches > in followups. Looks OK to me. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen
