Re: Improper io_opt setting for md raid5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 15, 2025 at 10:51:56AM -0600, Keith Busch wrote:
> > Then in drivers/scsi/sd.c, inside sd_revalidate_disk() from the following coce,
> > 3785         /*
> > 3786          * Limit default to SCSI host optimal sector limit if set. There may be
> > 3787          * an impact on performance for when the size of a request exceeds this
> > 3788          * host limit.
> > 3789          */
> > 3790         lim.io_opt = sdp->host->opt_sectors << SECTOR_SHIFT;
> 
> Checking where "opt_sectors" was introduced, 608128d391fa5c9 says it was
> to provide the host optimal sectors, but the io_opt limit is supposed to
> be the device's. Seems to be a mistmatch in usage here, as "opt_sectors"
> should only be the upper limit for "io_opt" rather than the starting
> value.

Oh, 'opt_sectors' does turn into an upper limit if sdkp->opt_xfer_blocks
is valid, so I guess either that value is either unusable or a larger
value than you're expecting.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux