Re: [PATCH v2 1/2] block: Split blk_crypto_fallback_split_bio_if_needed()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 11, 2025 at 10:18:51AM -0700, Bart Van Assche wrote:
> +static bool blk_crypto_fallback_split_bio_if_needed(struct bio **bio_ptr)
> +{
> +	struct bio *bio = *bio_ptr;
> +	unsigned int num_sectors;
> +
> +	num_sectors = blk_crypto_max_io_size(bio);

This would look a little nicer if you assigned the value at declaration
time:

	unsigned int num_sectors = blk_crypto_max_io_size(bio);

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux