On Fri, Jul 11, 2025 at 10:18:51AM -0700, Bart Van Assche wrote: > +static bool blk_crypto_fallback_split_bio_if_needed(struct bio **bio_ptr) > +{ > + struct bio *bio = *bio_ptr; > + unsigned int num_sectors; > + > + num_sectors = blk_crypto_max_io_size(bio); This would look a little nicer if you assigned the value at declaration time: unsigned int num_sectors = blk_crypto_max_io_size(bio); Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>