On 13/07/2025 11:00, Purva Yeshi wrote: > Fix Smatch-detected error: > drivers/block/floppy.c:3569 fd_locked_ioctl() error: > uninitialized symbol 'outparam'. > > Smatch may incorrectly warn about uninitialized use of 'outparam' > in fd_locked_ioctl(), even though all _IOC_READ commands guarantee > its initialization. Initialize outparam to NULL to make this explicit > and suppress the false positive. > > Signed-off-by: Purva Yeshi <purvayeshi550@xxxxxxxxx> > --- > V1 - https://lore.kernel.org/all/7dd94691-0b37-4855-be43-661f954275c8@xxxxxxxxx/T/#t > V2 - Initialize outparam to NULL to suppress Smatch false positive. > > drivers/block/floppy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index e97432032f01..24be0c2c4075 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -3411,7 +3411,7 @@ static int fd_locked_ioctl(struct block_device *bdev, blk_mode_t mode, > struct floppy_max_errors max_errors; > struct floppy_drive_params dp; > } inparam; /* parameters coming from user space */ > - const void *outparam; /* parameters passed back to user space */ > + const void *outparam = NULL; /* parameters passed back to user space */ > > /* convert compatibility eject ioctls into floppy eject ioctl. > * We do this in order to provide a means to eject floppy disks before Reviewed-by: Denis Efremov <efremov@xxxxxxxxx> Denis
