Re: [PATCH 4/5] block: add tracepoint for blkdev_zone_mgmt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/9/25 9:10 PM, Damien Le Moal wrote:
On 7/10/25 12:37 AM, Bart Van Assche wrote:
On 7/9/25 4:47 AM, Johannes Thumshirn wrote:
+    TP_printk("%d,%d %s %llu + %llu",
+          MAJOR(__entry->dev), MINOR(__entry->dev), __entry->rwbs,
+          (unsigned long long)__entry->sector,
+          __entry->nr_sectors)

sector_t is a synonym for u64. u64 is defined as unsigned long in
include/uapi/asm-generic/int-l64.h and is defined as unsigned long long
in include/uapi/asm-generic/int-ll64.h. Kernel code always includes
the int-ll64.h header file. In other words, I think the above cast is
superfluous for all CPU architectures supported by the Linux kernel.

%llu format will not work on 32-bits arch.

Huh? I think it would be a severe bug in the code in lib/vsprintf.c if
it would not support the %llu format on 32-bits architectures. Is there
perhaps a misunderstanding?

Bart.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux