On 6/27/25 1:28 PM, Ming Lei wrote: > On Fri, Jun 27, 2025 at 09:43:29AM +0530, Nilay Shroff wrote: >> >> >> On 6/26/25 8:13 PM, Ming Lei wrote: >> struct elevator_tags { >> /* num. of hardware queues for which tags are allocated */ >> unsigned int nr_hw_queues; >> /* depth used while allocating tags */ >> unsigned int nr_requests; >> /* The index 0 in @tags is used to store shared sched tags */ >> struct blk_mq_tags **tags; > > s/struct blk_mq_tags **tags/struct blk_mq_tags *tags[]; > > Then we can save one extra failure handling. Yeah I think that's the advantage with the flex array! > >> >> This seems like a clean and straightforward solution that should be easy to implement >> without much hassle. Please let me know if this still needs adjustment. > > I think we are in same page now. > Great! Thanks, --Nilay