On 6/25/25 10:15 PM, Christoph Hellwig wrote:
On Wed, Jun 25, 2025 at 12:54:50PM -0700, Bart Van Assche wrote:
Fix this by removing the superfluous queue freezing/unfreezing code from
queue_ra_store().
You'll need to explain why it is useless here.
If nobody objects I will add the following text to the patch
description:
"Freezing the request queue from inside a block layer sysfs store
callback function is essential when modifying parameters that affect how
bios or requests are processed, e.g. parameters that affect
bio_split_to_limit(). Freezing the request queue when modifying
parameters that do not affect bio nor request processing is not
necessary."
Thanks,
Bart.
