Re: [PATCH 4/8] nvme-pci: merge the simple PRP and SGL setup into a common helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 4/8] nvme-pci: merge the simple PRP and SGL setup into a common helper
From: Keith Busch <kbusch@xxxxxxxxxx>
Date: Mon, 23 Jun 2025 09:43:38 -0600
Cc: Jens Axboe <axboe@xxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Kanchan Joshi <joshi.k@xxxxxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Nitesh Shetty <nj.shetty@xxxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20250623141259.76767-5-hch@lst.de>
References: <20250623141259.76767-1-hch@lst.de> <20250623141259.76767-5-hch@lst.de>

On Mon, Jun 23, 2025 at 04:12:26PM +0200, Christoph Hellwig wrote:
> nvme_setup_prp_simple and nvme_setup_sgl_simple share a lot of logic.
> Merge them into a single helper that makes use of the previously added
> use_sgl tristate.

Looks good.

Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>

References:
- new DMA API conversion for nvme-pci v2
  - From: Christoph Hellwig
- [PATCH 4/8] nvme-pci: merge the simple PRP and SGL setup into a common helper
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 8/8] nvme-pci: rework the build time assert for NVME_MAX_NR_DESCRIPTORS
Next by Date: Re: [PATCH] block: don't use submit_bio_noacct_nocheck in blk_zone_wplug_bio_work
Previous by thread: [PATCH 4/8] nvme-pci: merge the simple PRP and SGL setup into a common helper
Next by thread: [PATCH 8/8] nvme-pci: rework the build time assert for NVME_MAX_NR_DESCRIPTORS
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]