Re: [PATCH 4/9] nvme-pci: refactor nvme_pci_use_sgls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 11, 2025 at 03:43:36PM +0200, Daniel Gomez wrote:
> > -	if (nvme_pci_use_sgls(dev, req, iod->sgt.nents))
> > +	if (use_sgl == SGL_FORCED ||
> > +	    (use_sgl == SGL_SUPPORTED &&
> 
> FORCED implies SUPPORTED, what about simplifying to:
> 
> if (use_sgl >= SGL_SUPPORTED)
> 
> or just do:
> 
> if (use_sgl)

For forced we unconditionally enter the sgl branch, for supported
we also need an additional condition.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux