On Jun 10, 2025 / 09:51, Keith Busch wrote:
> On Tue, Jun 10, 2025 at 07:31:10AM +0000, Shinichiro Kawasaki wrote:
> > Thanks for this v2. With the fix above, I was able to confirme that the test
> > case passes with v6.16-rc1 kernel. When I reverted the kernel commit below,
> > it failed. It looks working good as the fix confirmation.
> >
> > 43a67dd812c5 ("block: flip iter directions in blk_rq_integrity_map_user()")
>
> We should probably put a "Link:" tag in the commit message for this:
>
> https://lore.kernel.org/linux-block/20250603184752.1185676-1-csander@xxxxxxxxxxxxxxx/
>
> > To run the test case, I tried QEMU nvme emulation devices with some different
> > options. I found that the namespace should have format with metadata, and
> > extended LBA should be disabled. IOW, QEMU -drive option should have value
> > "pi=1,pil=1,ms=8" for the namespace.
>
> That's fine, though you don't need to set protection information
> capabilities for this. The test will still run if you enable it, but
> it's probably better if you just let it be opaque metadata. You can also
> test with ms=16 or ms=64 as both are supported by qemu's nvme device.
Ah, I see. I confirmed that the QEMU -drive option values "pi=1,pil=1" are not
required. Also, I confirmed that "ms=16" and "ms=64" work. Will reflect it to
the patch series to post.
>
> > I suggest to describe the device requirements in the test case comment. Also, I
> > suggest to check the requirements for the test case, and skip if the
> > requirements are not fulfilled. FYI, I prototyped such change as the patch
> > below. Please let me know what your think. If you are okay with it, I will
> > repost your patch together with my patch for common/rc and tests/nvme/rc as the
> > v3 series.
>
> Your changes look good. Thank you for the suggestions!
Sounds, good. Will post the series within a few days.
