On Fri, Jun 06, 2025 at 07:11:20AM +0530, Anuj gupta wrote: > Minor nit: should use `.nsid = nsid` instead of hardcoded `1` > > > + /* This should not be mappable for write commands */ > > Maybe reword this to: > /* This buffer is read-only, so using it for write passthrough should fail */ > -- makes the intent clearer. Err, I actually got this backwards. PROT_READ means we can write to the disk from that memory, but we can't read from the disk into it.