On Fri, Jun 06, 2025 at 09:03:11AM -0600, Jens Axboe wrote:
> On 6/6/25 8:58 AM, Daniel Wagner wrote:
> > FWIW, the contributor for the io_uring feature, stated that it improved
> > the performance for some workloads. Though, I think the whole
> > integration is sub-optimal, as a new io_uring is created/configured for
> > each get_log_page call. So only for a large transfers there is going to
> > help.
>
> That's crazy... What commit is that?
adee4ed1c8c8 ("ioctl: get_log_page by nvme uring cmd")
ioctl: get_log_page by nvme uring cmd
Use io_uring for fetching log pages.
This showed about a 10% performance improvement for some large log pages.
https://github.com/linux-nvme/libnvme/commit/adee4ed1c8c8
Should I rip it out? I am not really attached to it.
