Re: [PATCH] block: drop direction param from bio_integrity_copy_user()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Caleb Sander Mateos <csander@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] block: drop direction param from bio_integrity_copy_user()
From: Keith Busch <kbusch@xxxxxxxxxx>
Date: Tue, 3 Jun 2025 12:45:00 -0600
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20250603183133.1178062-1-csander@purestorage.com>
References: <20250603183133.1178062-1-csander@purestorage.com>

On Tue, Jun 03, 2025 at 12:31:32PM -0600, Caleb Sander Mateos wrote:
> direction is determined from bio, which is already passed in. Compute
> op_is_write(bio_op(bio)) directly instead of converting it to an iter
> direction and back to a bool.

Looks good.

Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>

References:
- [PATCH] block: drop direction param from bio_integrity_copy_user()
  - From: Caleb Sander Mateos

Prev by Date: Re: [RFC] fs: add ioctl to query protection info capabilities
Next by Date: Re: [PATCH] block: drop direction param from bio_integrity_copy_user()
Previous by thread: Re: [PATCH] block: drop direction param from bio_integrity_copy_user()
Next by thread: Re: [PATCH] block: drop direction param from bio_integrity_copy_user()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux