On Thu May 29, 2025 at 9:11 PM CEST, Boqun Feng wrote: > On Thu, May 29, 2025 at 10:10:24AM +0200, Benno Lossin wrote: >> Remove the error from the blanket implementations `impl<T, E> Init<T, E> >> for T` (and also for `PinInit`). Add implementations for `Result<T, E>`. >> >> This allows one to easily construct (un)conditional failing >> initializers. It also improves the compatibility with APIs that do not >> use pin-init, because users can supply a `Result<T, E>` to a function >> taking an `impl PinInit<T, E>`. >> >> Suggested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> >> Link: https://github.com/Rust-for-Linux/pin-init/pull/62/commits/58612514b256c6f4a4a0718be25298410e67387a >> [ Also fix a compile error in block. - Benno ] >> Signed-off-by: Benno Lossin <lossin@xxxxxxxxxx> > > The patch title is missing a "rust:" tag... but you can fix that in PR. Good catch, I originally ported this patch with my script, but then I decided to squash upstream and then copied the commit message from there, removing the prefix... > Reviewed-by: Boqun Feng <boqun.feng@xxxxxxxxx> Thanks! --- Cheers, Benno
