On Tue, May 20, 2025 at 03:39:07PM -0700, Luis Chamberlain wrote: > We don't seem to have unit tests for the DMA IOVA API, so I figured > we should add some so to ensure we don't regress moving forward, and it allows > us to extend these later. Its best to just extend existing tests though. I've > found two tests so I've extended them as part of this patchset: > > - drivers/dma/dmatest.c > - kernel/dma/map_benchmark.c > > However running the dmatest requires some old x86 emulation or some > non-upstream qemu patches for intel IOAT a q35 system. This make this > easier by providing a simple in-kernel fake-dma controller to let you test > run all dmatests on most systems. The only issue I found with that was not > being able to get the platform device through an IOMMU for DMA. If folks have > an idea of how to make it easy for a platform device to get an IOMMU for DMA > it would make it easier to allow us to leverage the existing dmatest for > IOVA as well. I only tried briefly with virtio and vfio_iommu_type1, but gave > up fast. Not sure if its easy to later allow a platform device like this > one to leverage it to make it easier for testing. I'm not sure if this is what you meant, but I'm configuring QEMU in nested VM mode. It gives me emulated hypervisor with working IOMMU path, which I tested with NVMe and RDMA. My QEMU command line is: /usr/bin/qemu-system-x86_64 -append root=/dev/root rw \ ignore_loglevel rootfstype=9p rootflags="cache=loose,trans=virtio" \ earlyprintk=serial,ttyS0,115200 console=hvc0 panic_on_warn=1 intel_iommu=on \ iommu=nopt iommu.forcedac=1 vfio_iommu_type1.allow_unsafe_interrupts=1 \ systemd.hostname=mtl-leonro-d-vm \ -chardev stdio,id=stdio,mux=on,signal=off \ -cpu host \ -device virtio-rng-pci \ -device virtio-balloon-pci \ -device isa-serial,chardev=stdio \ -device virtio-serial-pci \ -device virtconsole,chardev=stdio \ -device virtio-9p-pci,fsdev=host_fs,mount_tag=/dev/root \ -device virtio-9p-pci,fsdev=host_bind_fs0,mount_tag=bind0 \ -device virtio-9p-pci,fsdev=host_bind_fs1,mount_tag=bind1 \ -device virtio-9p-pci,fsdev=host_bind_fs2,mount_tag=bind2 \ -device intel-iommu,intremap=on \ -device nvme-subsys,id=bar \ -device nvme,id=baz,subsys=bar,serial=qux \ -device nvme-ns,drive=foo,bus=baz,logical_block_size=4096,physical_block_size=4096,ms=16 \ -drive file=/home/leonro/.cache/mellanox/mkt/nvme-1g.raw,format=raw,if=none,id=foo \ -enable-kvm \ -fsdev local,id=host_bind_fs2,security_model=none,path=/home/leonro \ -fsdev local,id=host_bind_fs0,security_model=none,path=/plugins \ -fsdev local,id=host_fs,security_model=none,path=/mnt/self \ -fsdev local,id=host_bind_fs1,security_model=none,path=/logs \ -fw_cfg etc/sercon-port,string=2 \ -kernel /home/leonro/src/kernel/arch/x86/boot/bzImage \ -m 4G \ -machine q35,kernel-irqchip=split \ -mon chardev=stdio \ -net nic,model=virtio,macaddr=52:54:9a:c5:60:66 \ -net user,hostfwd=tcp:127.0.0.1:54409-:22 \ -no-reboot \ -nodefaults \ -nographic \ -smp 64 \ -vga none% > > The kernel/dma/map_benchmark.c test is extended as well, for that I was > able to add follow the instructions on the first commit from that test, > by unbinding a device and attaching it to the map benchmark. > > I tried twiddle a mocked IOMMU with iommufd on a q35 guest, but alas, > that just didn't work as I'd hope, ie, nothing, and so this is the best > I have for now to help test IOVA DMA API on a virtualized setup. > > Let me know if others have other recomendations. > > The hope is to get a CI eventually going to ensure these don't regress. > > Luis Chamberlain (6): > fake-dma: add fake dma engine driver > dmatest: split dmatest_func() into helpers > dmatest: move printing to its own routine > dmatest: add IOVA tests > dma-mapping: benchmark: move validation parameters into a helper > dma-mapping: benchmark: add IOVA support > > drivers/dma/Kconfig | 11 + > drivers/dma/Makefile | 1 + > drivers/dma/dmatest.c | 795 ++++++++++++------ > drivers/dma/fake-dma.c | 718 ++++++++++++++++ > include/linux/map_benchmark.h | 11 + > kernel/dma/Kconfig | 4 +- > kernel/dma/map_benchmark.c | 512 +++++++++-- > .../testing/selftests/dma/dma_map_benchmark.c | 145 +++- > 8 files changed, 1864 insertions(+), 333 deletions(-) > create mode 100644 drivers/dma/fake-dma.c > > -- > 2.47.2 > >
