On 5/15/25 12:19 AM, Niklas Cassel wrote:
Hello Bart,
On Wed, May 14, 2025 at 01:29:36PM -0700, Bart Van Assche wrote:
submit_bio() may be called recursively. To limit the stack depth, recursive
calls result in bios being added to a list (current->bio_list).
__submit_bio_noacct() sets up that list and maintains two lists with
requests:
* bio_list_on_stack[0] is the list with bios submitted by recursive
submit_bio() calls from inside the latest __submit_bio() call.
* bio_list_on_stack[1] is the list with bios submitted by recursive
submit_bio() calls from inside previous __submit_bio() calls.
Make sure that bios are submitted to lower devices in the order these
have been submitted by submit_bio() by adding new bios at the end of the
list instead of at the front.
This patch fixes unaligned write errors that I encountered with F2FS
submitting zoned writes to a dm driver stacked on top of a zoned UFS
device.
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Damien Le Moal <dlemoal@xxxxxxxxxx>
Cc: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>
Cc: Ming Lei <ming.lei@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Here you add stable to Cc, but you don't specify either
1) a minimum version e.g.
stable@xxxxxxxxxxxxxxx # v6.8+
or
2) a Fixes tag.
Hi Niklas,
Let's add the following to this patch:
Fixes: 79bd99596b73 ("blk: improve order of bio handling in
generic_make_request()")
Neil, since that commit was authored by you: the commit message is
elaborate but the names of the drivers that needed that commit have
not been mentioned. Which drivers needed that change? Additionally,
can you please help with reviewing this patch:
https://lore.kernel.org/linux-block/20250514202937.2058598-2-bvanassche@xxxxxxx/
Thanks,
Bart.
