Re: [PATCH 1/2] block: don't quiesce queue for calling elevator_set_none()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/8/25 2:28 PM, Ming Lei wrote:
> blk_mq_freeze_queue() can't be called on quiesced queue, otherwise it may
> never return if there is any queued requests.
> 
> Fix it by removing quiesce queue around elevator_set_none() because
> elevator_switch() does quiesce queue in case that we need to switch
> to none really.
> 
> Fixes: 1e44bedbc921 ("block: unifying elevator change")
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>

Maybe you should add a link to the issue this commit fixed. I just
saw Shinichiro reproduced it here [1].

[1] https://lore.kernel.org/all/mlycu6p6zl5z5mmqau7otbfw35kcvnajpsnm3hokpfnafc3bwh@m5dp43ypdfpz/

Otherwise changes look good to me:
Reviewed-by: Nilay Shroff <nilay@xxxxxxxxxxxxx>
 




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux