Re: [PATCH] block: always allocate integrity buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 07, 2025 at 08:37:59AM -0700, Keith Busch wrote:
> @@ -412,6 +415,8 @@ void blk_integrity_verify_iter(struct bio *bio, struct bvec_iter *saved_iter)
>  	struct bvec_iter bviter;
>  	struct bio_vec bv;
>  
> +	if (bi->flags & BLK_INTEGRITY_NOVERIFY)
> +		return;
>  	/*
>  	 * At the moment verify is called bi_iter has been advanced during split
>  	 * and completion, so use the copy created during submission here.

I think this may not be the best place to check this flags. This
function is called from a workqueue that defers completing the bio until
after the verification. But since verify is disabled, the deferred
completion isn't necessary and just adds latency, so I'll a send a v2
real quick to short cut that completion handling.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux