On Tue, May 06, 2025 at 11:44:27PM +0530, Kanchan Joshi wrote: > On Tue, May 6, 2025 at 9:56 PM Keith Busch <kbusch@xxxxxxxxxx> wrote: > > > > You're right, should have been min. Because "runs" is a u64 and the > > queue_limit is a u32, so U32_MAX is the upper limit, but it's not > > supposed to exceed "runs". > > Would it be better to change write_stream_granularity to "long > unsigned int" so that it matches with what is possible in nvme? That type is still 4 bytes on many 32-bit archs, but I know what you mean (unsigned long long). I didn't think we'd see reclaim units approach 4GB, but if you think it's possible, may as well have the queue_limit type be large enough to report it.
