Re: [PATCH 16/17] zonefs: use bdev_rw_virt in zonefs_read_super

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22.04.25 16:31, Christoph Hellwig wrote:
> +	super = kmalloc(PAGE_SIZE, GFP_KERNEL);
> +	if (!super)

[...]

> +	ret = bdev_rw_virt(sb->s_bdev, 0, super, PAGE_SIZE, REQ_OP_READ);

Can we change these two PAGE_SIZE into ZONEFS_SUPER_SIZE which is 
semantically more correct?

Other than that,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux