Re: [PATCH V4] loop: Add sanity check for read/write_iter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Lizhi Xu <lizhi.xu@xxxxxxxxxxxxx>
Subject: Re: [PATCH V4] loop: Add sanity check for read/write_iter
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 28 Apr 2025 07:26:15 -0700
Cc: hch@xxxxxxxxxxxxx, axboe@xxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ming.lei@xxxxxxxxxx, syzbot+6af973a3b8dfd2faefdc@xxxxxxxxxxxxxxxxxxxxxxxxx, syzkaller-bugs@xxxxxxxxxxxxxxxx
In-reply-to: <20250428141544.3279719-1-lizhi.xu@windriver.com>
References: <aA-HSxKfbM6WCgek@infradead.org> <20250428141544.3279719-1-lizhi.xu@windriver.com>

On Mon, Apr 28, 2025 at 10:15:44PM +0800, Lizhi Xu wrote:
> +	if ((file->f_mode & FMODE_WRITE) && (!file->f_op->write_iter))

No need for the braces around !file->f_op->write_iter.

> +	if ((mode & BLK_OPEN_WRITE) && (!file->f_op->write_iter))

Same here.  Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- [PATCH V5] loop: Add sanity check for read/write_iter
  - From: Lizhi Xu

References:
- Re: [PATCH V3] loop: Add sanity check for read/write_iter
  - From: Christoph Hellwig
- [PATCH V4] loop: Add sanity check for read/write_iter
  - From: Lizhi Xu

Prev by Date: [PATCH V4] loop: Add sanity check for read/write_iter
Next by Date: Re: [PATCH 5/8] ublk: factor out ublk_start_io() helper
Previous by thread: [PATCH V4] loop: Add sanity check for read/write_iter
Next by thread: [PATCH V5] loop: Add sanity check for read/write_iter
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux