Hi,
On Sun, Apr 27, 2025 at 5:48 PM Salah Triki <salah.triki@xxxxxxxxx> wrote:
>
> Every ktype must provides a .release function that will be called after
> the last kobject_put.
>
> Signed-off-by: Salah Triki <salah.triki@xxxxxxxxx>
This change cause crashing during unmap device.
We already have rnbd_client_release from rnbd_client_ops, so no memleak.
Nacked.
Thx!
> ---
> drivers/block/rnbd/rnbd-clt-sysfs.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c
> index 6ea7c12e3a87..144aea1466a4 100644
> --- a/drivers/block/rnbd/rnbd-clt-sysfs.c
> +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c
> @@ -475,9 +475,17 @@ void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev)
> }
> }
>
> +static void rnbd_dev_release(struct kobject *kobj)
> +{
> + struct rnbd_clt_dev *dev = container_of(kobj, struct rnbd_clt_dev, kobj);
> +
> + kfree(dev);
> +}
> +
> static const struct kobj_type rnbd_dev_ktype = {
> .sysfs_ops = &kobj_sysfs_ops,
> .default_groups = rnbd_dev_groups,
> + .release = rnbd_dev_release,
> };
>
> static int rnbd_clt_add_dev_kobj(struct rnbd_clt_dev *dev)
> --
> 2.43.0
>
