On Sat, Apr 26, 2025 at 10:58:01PM -0600, Caleb Sander Mateos wrote: > ublk_dispatch_req() currently handles 3 different cases: incoming ublk > requests that don't need to wait for a data buffer, incoming requests > that do need to wait for a buffer, and resuming those requests once the > buffer is provided. But the call site that provides a data buffer > (UBLK_IO_NEED_GET_DATA) is separate from those for incoming requests. > > So simplify the function by splitting the UBLK_IO_NEED_GET_DATA case > into its own function ublk_get_data(). This avoids several redundant > checks in the UBLK_IO_NEED_GET_DATA case, and streamlines the incoming > request cases. > > Don't call ublk_fill_io_cmd() for UBLK_IO_NEED_GET_DATA, as it's no > longer necessary to set io->cmd or the UBLK_IO_FLAG_ACTIVE flag for > ublk_dispatch_req(). > > Since UBLK_IO_NEED_GET_DATA no longer relies on ublk_dispatch_req() > calling io_uring_cmd_done(), return the UBLK_IO_RES_OK status directly > from the ->uring_cmd() handler. > > Signed-off-by: Caleb Sander Mateos <csander@xxxxxxxxxxxxxxx> Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx> thanks, Ming
