Re: [PATCH V3 15/20] block: fail to show/store elevator sysfs attribute if elevator is dying

[Christoph Hellwig <hch@xxxxxx>]

On Thu, Apr 24, 2025 at 11:21:38PM +0800, Ming Lei wrote:
> +	if (test_bit(ELEVATOR_FLAG_DYING, &e->flags))
> +		error = -ENODEV;
> +	else
> +		error = e->type ? entry->show(e, page) : -ENOENT;

Weird style mix, I'd expand the check for ->type to a proper else
if here as well.  But how can e->type actually be NULL here to start
with?