On Thu, Apr 24, 2025 at 11:21:32PM +0800, Ming Lei wrote: > +static int __elevator_change(struct request_queue *q, > + const char *elevator_name) There's still not good reason for this helper. I'd suggest you add the two first attached patches before this one (it'll need a bi of reabsing as all of them are after your entire sweries right now) and then fold the third one into this, which will give us less code and a cleaner interface.