Re: [PATCH V3 04/20] block: use q->elevator with ->elevator_lock held in elv_iosched_show()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx
Subject: Re: [PATCH V3 04/20] block: use q->elevator with ->elevator_lock held in elv_iosched_show()
From: Nilay Shroff <nilay@xxxxxxxxxxxxx>
Date: Fri, 25 Apr 2025 16:23:39 +0530
Cc: Shinichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>, Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <20250424152148.1066220-5-ming.lei@redhat.com>
References: <20250424152148.1066220-1-ming.lei@redhat.com> <20250424152148.1066220-5-ming.lei@redhat.com>
User-agent: Mozilla Thunderbird


On 4/24/25 8:51 PM, Ming Lei wrote:
> Use q->elevator with ->elevator_lock held in elv_iosched_show(), since
> the local cached elevator reference may become stale after getting
> ->elevator_lock.
> 
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>

Looks good to me:
Reviewed-by : Nilay Shroff <nilay@xxxxxxxxxxxxx>

References:
- [PATCH V3 00/20] block: unify elevator changing and fix lockdep warning
  - From: Ming Lei
- [PATCH V3 04/20] block: use q->elevator with ->elevator_lock held in elv_iosched_show()
  - From: Ming Lei

Prev by Date: [RFC PATCHv2 3/3] nvme: rename nvme_mpath_shutdown_disk to nvme_mpath_remove_disk
Next by Date: Re: [PATCH V3 07/20] block: prevent adding/deleting disk during updating nr_hw_queues
Previous by thread: Re: [PATCH V3 04/20] block: use q->elevator with ->elevator_lock held in elv_iosched_show()
Next by thread: Re: [PATCH V3 04/20] block: use q->elevator with ->elevator_lock held in elv_iosched_show()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]